feat(1-3267): use new API for chart creation #9149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
thomasheartman
commented
Jan 28, 2025
Comment on lines
+477
to
+497
| <Grid container component='header' spacing={2}> | ||
| <Grid item xs={12} md={10}> | ||
| <NetworkTrafficUsagePlanSummary | ||
| usageTotal={usageTotal} | ||
| includedTraffic={includedTraffic} | ||
| overageCost={overageCost} | ||
| estimatedMonthlyCost={estimatedMonthlyCost} | ||
| /> | ||
| <PeriodSelector | ||
| selectedPeriod={period} | ||
| setPeriod={setPeriod} | ||
| </Grid> | ||
| <Grid item xs={12} md={2}> | ||
| <Select | ||
| id='dataperiod-select' | ||
| name='dataperiod' | ||
| options={selectablePeriods} | ||
| value={period} | ||
| onChange={(e) => setPeriod(e.target.value)} | ||
| style={{ | ||
| minWidth: '100%', | ||
| marginBottom: theme.spacing(2), | ||
| }} | ||
| formControlStyles={{ width: '100%' }} |
There was a problem hiding this comment.
Revert to the old version. The flag has moved up a level, so we don't need to check it here anymore
daveleek
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the new /traffic-search API behind a flag. When active, you'll be able to select month ranges as well as specific single months.
Largely copies the existing network traffic component, and adds some minor tweaks to make it work with the new data.
This is quite rough, but it gives us a base to build on for later. There's still things that we need to solve for in following PRs.