test: fix timezone-related inconsistencies in tests #9083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
nunogois
force-pushed
the
test-make-tests-timezone-agnostic
branch
from
53c25b9 to
746acce
Compare
nunogois
commented
Jan 13, 2025
| expect(rows.find((row) => row.date === '2024-11-07').count).toBe(1); // user2 within retention, user1 expired | ||
| expect(rows.find((row) => row.date === '2024-11-10').count).toBe(0); // Both users expired | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Confirmed with @sjaanus and we can remove this test now.
nunogois
force-pushed
the
test-make-tests-timezone-agnostic
branch
from
0245bea to
4e2f7ae
Compare
nunogois
changed the title
sjaanus
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-3132/fix-tests-to-make-them-timezone-agnostic
Noticed our tests failed for me locally since I'm on a different timezone (Lisbon time, GMT).
This fixes these timezone-related inconsistencies.
Before
After