-
-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1-3083: add remaining lifecycle header + tooltip #8722
Merged
thomasheartman
merged 11 commits into
main
from
1-3083/add-remaining-components-for-lifecycle
Nov 13, 2024
Merged
1-3083: add remaining lifecycle header + tooltip #8722
thomasheartman
merged 11 commits into
main
from
1-3083/add-remaining-components-for-lifecycle
Nov 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
thomasheartman
changed the title
1-3083: add remaining bits of lifecycle widget
1-3083: add remaining lifecycle header + tooltip
Nov 13, 2024
sjaanus
approved these changes
Nov 13, 2024
thomasheartman
deleted the
1-3083/add-remaining-components-for-lifecycle
branch
November 13, 2024 09:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a header and a tooltip to the lifecycle widget. Most of the changes in ProjectLifecycleSummary is indentation changes due to wrapping the component in another row container.
Additionally, this PR touches the
HelpIcon
component because we'd like the tooltip to be wider than what we currently set as the default for the help icon. The help icon uses the html tooltip component, which has a maxWidth prop, but it does not expose that. So I've adjusted it to let you do that.Header with tooltip: