Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: archive is now part of project feature list #8587

Merged
merged 1 commit into from
Oct 30, 2024
Merged

feat: archive is now part of project feature list #8587

merged 1 commit into from
Oct 30, 2024
+107 −18

Conversation

sjaanus
Copy link
Contributor

@sjaanus sjaanus commented Oct 30, 2024

image

@vercel Vercel
Copy link

vercel bot commented Oct 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 7:01am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 7:01am

@github-actions GitHub Actions
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

thomasheartman
thomasheartman reviewed Oct 30, 2024
View reviewed changes
...tend/src/component/project/Project/PaginatedProjectFeatureToggles/ProjectOverviewFilters.tsx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not something that's blocking for now, but is "Show only archived is true" really the best way to phrase it / display it to users? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most easiest to understand, we can change it in overhaul.

frontend/src/component/project/Project/PaginatedProjectFeatureToggles/hooks/useRowActions.tsx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do we show these? Is this the bar in the screenshot or is it a row? Just wondering whether we're always showing the option to revive and delete or if it's done conditionally somehow. I'm assuming that it's only shown where it makes sense, but I'm not seeing exactly where that's happening 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only if archived filter is on, so only archived flags are displayed.

@sjaanus sjaanus merged commit 5f67dce into main Oct 30, 2024
13 checks passed
@sjaanus sjaanus deleted the archive-ui branch October 30, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasheartman thomasheartman thomasheartman approved these changes

Assignees

@sjaanus sjaanus

Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjaanus @thomasheartman