fix: invalid spreading of keys into table rows everywhere #8551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes MUI prop spreading warnings in all the table rows I could find through a quick search in the code base.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
thomasheartman
commented
Oct 28, 2024
frontend/src/component/changeRequest/ProjectChangeRequests/ProjectChangeRequests.tsx
Outdated
Show resolved
Hide resolved
…jectChangeRequests.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes invalid prop spreading warnings in all the table rows I
could find through a quick search in the code base.
The issue is that you can't spread the "key" prop into a component. It must be an explicit prop.
The process is the same everywhere:
row.getRowProps()into the component, we extract and split it:const {key, ...rowProps} = row.getRowProps().