Email template for Productivity Report #8532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
kwasniew
reviewed
Oct 24, 2024
| @@ -34,7 +34,7 @@ | |||
| "main": "./dist/lib/server-impl.js", | |||
| "scripts": { | |||
| "start": "TZ=UTC node ./dist/server.js", | |||
| "copy-templates": "copyfiles -u 1 src/mailtemplates/**/*.mustache dist/", | |||
| "copy-templates": "copyfiles -u 1 src/mailtemplates/**/* dist/", | |||
There was a problem hiding this comment.
what else did we copy before?
kwasniew
reviewed
Oct 24, 2024
kwasniew
reviewed
Oct 24, 2024
| @@ -28,6 +28,11 @@ export interface IEmailEnvelope { | |||
| subject: string; | |||
| html: string; | |||
| text: string; | |||
| attachments?: { | |||
There was a problem hiding this comment.
what's the rationale for this? what did we do before?
kwasniew
reviewed
Oct 24, 2024
| @@ -522,32 +527,48 @@ export class EmailService { | |||
| } | |||
|
|
|||
| async sendProductivityReportEmail( | |||
| userName: string, | |||
There was a problem hiding this comment.
it will be a breaking change for my enterprise PR so we need to cordinate
kwasniew
reviewed
Oct 24, 2024
kwasniew
reviewed
Oct 24, 2024
kwasniew
reviewed
Oct 24, 2024
| path: string; | ||
| cid: string; | ||
| } { | ||
| const topPath = path.resolve(__dirname, '../../mailtemplates'); |
There was a problem hiding this comment.
we need to check if everything works with base paths in sandbox
There was a problem hiding this comment.
this is the same as templates, but yes, we can check
kwasniew
reviewed
Oct 24, 2024
src/mailtemplates/productivity-report/productivity-report.html.mustache
Outdated
Show resolved
Hide resolved
kwasniew
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes