Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: patch text when trying to add a root role group #8470

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

sighphyre
Copy link
Member

This changes the warning on adding group root roles to cover all roles rather than just Editor or Admin. This got opened to Viewers in a 2K line monster PR that was mostly refactor so I'm assuming this was an accident but it's not a dangerous accident

Discussion

Okay so why change the warning rather than change the code?

Two reasons.

  1. This has been like this for a year and a half. It was changed before the feature entered GA, so users are probably used to it by now. Seems rude to take things away and it's harmless to keep it
  2. It's consistent with everything else to have all 3 roles displayed and removes an edge case in the code

Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 8:38am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Oct 17, 2024 8:38am

Copy link
Member

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@nunogois nunogois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember seeing something like this before. I can never fully understand why you can't assign groups with root roles to projects, but the text makes sense to me.

@sighphyre
Copy link
Member Author

I remember seeing something like this before. I can never fully understand why you can't assign groups with root roles to projects, but the text makes sense to me.

I'd have to check the backend code, it's been a while but iirc, the rather loose reasoning is that there's no point. Admins and Editors already have everything a group could grant so this adds confusion without benefit

@sighphyre sighphyre merged commit d5ddbdd into main Oct 17, 2024
13 checks passed
@sighphyre sighphyre deleted the fix/text-warning-on-root-role-groups branch October 17, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants