feat: release plans nav menu item and icon suggestion #8469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
|
Is this behind a feature flag? |
daveleek
commented
Oct 17, 2024
| component: ReleaseManagement, | ||
| type: 'protected', | ||
| menu: { advanced: true, mode: ['enterprise'] }, | ||
| flag: 'releasePlans', |
There was a problem hiding this comment.
This @gardleopard makes sure it's shown only when the specified flag is 'true'
- Another interesting side effect, setting that flag to true negates any enterprise check for the link, so would show up in both OSS and Pro, but the route will still yield a 404 in that case.
Still, it's something we might want to look at (but I feel that's beyond the scope of this PR, I'm making a bug task for it though)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
Release managementitem to the nav menu and an empty releasemgmt page component.Temporarily suggests the MUI
Launchicon as the release mgmt link icon.