Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: flag for webhook domain logging #8413

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

daveleek
Copy link
Contributor

Introduces a flag for webhook info-logging of invocations against domain. This should be on for our cloud customers but default to off so it doesn't clutter logs of OSS/Selfhosted

Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 7:19am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 7:19am

Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Member

@nunogois nunogois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume these are supposed to be long-lived flags that are always enabled for cloud customers? If so, I wonder if we can find a better way to detect we are running a cloud instance, e.g., some property in UnleashConfig.

@daveleek daveleek merged commit b1cdde0 into main Oct 10, 2024
9 checks passed
@daveleek daveleek deleted the chore/webhook-domain-logging-flag branch October 10, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants