chore: implement an Unleash AI service #8408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Dependency ReviewThe following issues were found:
OpenSSF ScorecardScorecard details
Scanned Manifest Filespackage.json
|
nunogois
force-pushed
the
chore-unleash-ai-service
branch
from
5d24da9 to
93d4bd1
Compare
sighphyre
approved these changes
Oct 10, 2024
| ); | ||
|
|
||
| return response; | ||
| } catch (error) { |
There was a problem hiding this comment.
What's the try/catch here for? Debugging?
There was a problem hiding this comment.
Anything can go wrong when calling this method, so this allows us to forward either the success response or the error message back to the assistant, allowing it to handle both scenarios gracefully.
| } | ||
|
|
||
| chat( | ||
| messages: ChatCompletionMessageParam[], |
There was a problem hiding this comment.
What's the intent here? Does the chat history live on the UI at the moment? Can't quite see how this works behind a load balancer
There was a problem hiding this comment.
We're still on the early stage of this project where we're mostly just migrating code from the hackathon branch and polishing it a bit. So for now the chat history still lives in the UI. We have another task for later that moves this ownership to the server.
There was a problem hiding this comment.
In the same vein, I'm pretty sure our toggle-flag tool is not respecting change requests currently, which is another task we have for later.
| featureSearchService, | ||
| user, | ||
| }: searchFlagOperationalParams): RunnableToolFunctionWithParse<searchFlagParams> => ({ | ||
| type: 'function', |
There was a problem hiding this comment.
This is pretty cool! How well does this work in practice? Does OpenAI use all of these terms effectively?
There was a problem hiding this comment.
In general, based on the hackathon, this worked pretty well, so it should! We can always fine tune if needed.
If we're specifically talking about this search-flag tool I'm not sure because I haven't tried it yet 😄 It's a new tool to replace the old get-flag one. Good news is that we'll find out soon enough whether this works like we expect it to!
| }, | ||
| enabled: { | ||
| type: 'boolean', | ||
| description: 'The desired enabled status of the flag', |
There was a problem hiding this comment.
Maybe your intent is to tackle this in the base prompt but I can see this causing confusion with constraints forcing a flag off
There was a problem hiding this comment.
I'm not sure I follow 🤔 If a flag is off because of constraints, that doesn't matter in the perspective of our assistant, because it's only concerned about the admin side of Unleash, right?
I'm curious to know what you have in mind.
|
Closing this in favor of a refined approach based on internal discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-2789/create-an-ai-service
Implements an Unleash AI service with 3 tools:
Depends on #8400