Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: environments route should be hidden from menu for open-source #8397

Merged
merged 1 commit into from
Oct 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions frontend/src/component/common/util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ export const filterByConfig =
return Boolean(config[r.configFlag]);
}

const isOss = !config?.versionInfo?.current?.enterprise;
if (isOss && r.enterprise) {
return false;
}

return true;
};

Expand Down
1 change: 1 addition & 0 deletions frontend/src/component/menu/routes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -511,6 +511,7 @@ export const getCondensedRoutes = (routes: IRoute[]): INavigationMenuItem[] => {
menu: route.menu,
configFlag: route.configFlag,
notFlag: route.notFlag,
enterprise: route.enterprise,
};
});
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -230,10 +230,14 @@ const ProjectEnvironmentList = () => {
initialValue={globalFilter}
onChange={setGlobalFilter}
/>
<PageHeader.Divider />
<Link component={RouterLink} to='/environments'>
Configure environments
</Link>
{!isOss() ? (
<>
<PageHeader.Divider />
<Link component={RouterLink} to='/environments'>
Configure environments
</Link>
</>
) : null}
</>
}
/>
Expand Down
1 change: 1 addition & 0 deletions frontend/src/interfaces/route.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export interface INavigationMenuItem {
notFlag?: keyof UiFlags;
configFlag?: keyof IUiConfig;
group?: string;
enterprise?: boolean;
}

interface IRouteMenu {
Expand Down
Loading