Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up stale flag: addonUsageMetrics and event emitting from addons #8381

Merged
merged 17 commits into from
Oct 14, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: fix simple addon test class
daveleek committed Oct 11, 2024
commit 47e6c3b0bb35f8ca6a59873178d3c0a7e76e8e53
4 changes: 1 addition & 3 deletions src/lib/services/addon-service-test-simple-addon.ts
Original file line number Diff line number Diff line change
@@ -75,12 +75,10 @@ export default class SimpleAddon extends Addon {
}

// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
async handleEvent(event: IEvent, parameters: any): Promise<string> {
async handleEvent(event: IEvent, parameters: any): Promise<void> {
this.events.push({
event,
parameters,
});

return 'success';
}
}