Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make signals visible on event timeline for non admins #8364

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

nunogois
Copy link
Member

@nunogois nunogois commented Oct 4, 2024

https://linear.app/unleash/issue/2-2743/open-the-signal-query-endpoint-to-everyone-not-only-admins

The new signal query endpoint is now open for every Unleash user, not only admins.

This PR allows non-admins to view signals in the event timeline. It also updates the signals tooltip to be shown to all users, not just admins, under the following assumptions:

  • !signalsSuggestionSeen - Current user has not dismissed the signals tip
  • isEnterprise() - Enterprise instance
  • signalsEnabled - The signals feature flag is enabled
  • !signalsLoading - Signals have finished loading (avoids flickering)
  • signals.length === 0 - We can't find any signals in the selected timespan

Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 9:41am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Oct 4, 2024 9:41am

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nunogois nunogois merged commit 3fb683f into main Oct 4, 2024
13 checks passed
@nunogois nunogois deleted the chore-event-timeline-signals-for-non-admins branch October 4, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants