feat: connect dashboard static widgets to data #6062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kwasniew
reviewed
Jan 30, 2024
| @@ -18,6 +18,19 @@ const StyledGrid = styled(Box)(({ theme }) => ({ | |||
| export const ExecutiveDashboard: VFC = () => { | |||
| const { executiveDashboardData, loading, error } = useExecutiveDashboard(); | |||
|
|
|||
| const calculateFlagPerUsers = () => { | |||
There was a problem hiding this comment.
I was considering this calculation in the backend and decided it's ok to have it in frontend for now. What do you prefer?
|
Agree. It is a very simple derivation of data.
tir. 30. jan. 2024 kl. 08:43 skrev Mateusz Kwasniewski <
***@***.***>:
… ***@***.**** commented on this pull request.
------------------------------
In frontend/src/component/executiveDashboard/ExecutiveDashboard.tsx
<#6062 (comment)>:
> @@ -18,6 +18,19 @@ const StyledGrid = styled(Box)(({ theme }) => ({
export const ExecutiveDashboard: VFC = () => {
const { executiveDashboardData, loading, error } = useExecutiveDashboard();
+ const calculateFlagPerUsers = () => {
I was considering this calculation in the backend and decided it's ok to
have it in frontend for now. What do you prefer?
—
Reply to this email directly, view it on GitHub
<#6062 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD2WIPWIWMCK6JMUGFKK2M3YRCQCDAVCNFSM6AAAAABCPVCGHSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNJQGQYTOMRYGQ>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
kwasniew
reviewed
Jan 30, 2024
| @@ -30,8 +43,11 @@ export const ExecutiveDashboard: VFC = () => { | |||
| /> | |||
| </Box> | |||
| <StyledGrid> | |||
| <UserStats /> | |||
| <FlagStats /> | |||
| <UserStats count={executiveDashboardData.users.total || 0} /> | |||
There was a problem hiding this comment.
Backend is deliberately not returning null/undefined values so that we don't need to be defensive in the UI
kwasniew
reviewed
Jan 30, 2024
| @@ -18,6 +18,19 @@ const StyledGrid = styled(Box)(({ theme }) => ({ | |||
| export const ExecutiveDashboard: VFC = () => { | |||
| const { executiveDashboardData, loading, error } = useExecutiveDashboard(); | |||
|
|
|||
| const calculateFlagPerUsers = () => { | |||
| if ( | |||
| !executiveDashboardData.users.total || | |||
|
I was following what the types were telling me here. Lets look into it.
tir. 30. jan. 2024 kl. 08:45 skrev Mateusz Kwasniewski <
***@***.***>:
… ***@***.**** commented on this pull request.
------------------------------
In frontend/src/component/executiveDashboard/ExecutiveDashboard.tsx
<#6062 (comment)>:
> @@ -18,6 +18,19 @@ const StyledGrid = styled(Box)(({ theme }) => ({
export const ExecutiveDashboard: VFC = () => {
const { executiveDashboardData, loading, error } = useExecutiveDashboard();
+ const calculateFlagPerUsers = () => {
+ if (
+ !executiveDashboardData.users.total ||
should never occur
—
Reply to this email directly, view it on GitHub
<#6062 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD2WIPRQLG34OLG2RR66OGTYRCQJNAVCNFSM6AAAAABCPVCGHSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNJQGQZDAMRZGY>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
FredrikOseberg
force-pushed
the
feat/connect-widgets-to-data
branch
from
7041573 to
e4b3619
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR connects the static widgets to actual data