Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/dashboard chart tooltip #6038

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Feat/dashboard chart tooltip #6038

merged 1 commit into from
Jan 26, 2024

Conversation

Tymek
Copy link
Member

@Tymek Tymek commented Jan 25, 2024

Initial version of new chart tooltip

image

Copy link

vercel bot commented Jan 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 26, 2024 11:28am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Jan 26, 2024 11:28am

} = chart?.legend?.options || {
labels: {},
};
return (chart as any)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some issues with types on Chart.js. Hopefully I'll be able to fix it in next iteration

@Tymek Tymek marked this pull request as ready for review January 26, 2024 11:33
: '';
},
enabled: false,
external: (context: any) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it gonna change to proper types?

radius: 0,
},
},
// cubicInterpolationMode: 'monotone',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it leftover or wip?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP

labels: {
boxWidth: 12,
padding: 30,
// usePointStyle: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it leftover or wip?

@Tymek Tymek merged commit 61c6583 into main Jan 26, 2024
12 checks passed
@Tymek Tymek deleted the feat/dashboard-chart-tooltip branch January 26, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants