Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: This helps output the migrations being applied #6004

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

gastonfournier
Copy link
Contributor

About the changes

This outputs to console.log but should be indexable:
image

Copy link

vercel bot commented Jan 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jan 23, 2024 1:54pm
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Jan 23, 2024 1:54pm

Copy link
Contributor

@gardleopard gardleopard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gardleopard
Copy link
Contributor

Might be to noisy
maybe we should not??

Copy link
Contributor

@gardleopard gardleopard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets think about it, might be to much information

@gastonfournier
Copy link
Contributor Author

Might be to noisy maybe we should not??

Sure, this is the type of thing to consider. You only get the migrations that are applied, if your DB is up-to-date with the migration you get this instead:
image

So we should only see the log of the migrations applied by the pod running the migrations. The others should just print something like above

Copy link
Contributor

@gardleopard gardleopard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then its good for me

@gastonfournier gastonfournier merged commit 82ac5a4 into main Jan 23, 2024
8 checks passed
@gastonfournier gastonfournier deleted the info-migration-log branch January 23, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants