Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: Make /edge/metrics toggleable by toggle #6003

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

chriswk
Copy link
Member

@chriswk chriswk commented Jan 23, 2024

Previously we used a killswitch and returned 404 if the feature was enabled. This flips that to a default disabled toggle, that has to be turned on to handle old Edge (pre 17.0.0) posting bulk metrics

@chriswk chriswk self-assigned this Jan 23, 2024
Copy link

vercel bot commented Jan 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 0:13am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2024 0:13am

Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing snapshot update but looks good

@chriswk chriswk force-pushed the task/edgeBulkMetricsNowFeatureToggle branch from cca2b1d to 5d6041e Compare January 24, 2024 11:57
Previously we used a killswitch and returned 404 if the feature was
enabled. This flips that to a default disabled toggle, that has to be
turned on to handle old Edge (pre 17.0.0) posting bulk metrics
@chriswk chriswk merged commit 3acdfc2 into main Jan 24, 2024
12 checks passed
@chriswk chriswk deleted the task/edgeBulkMetricsNowFeatureToggle branch January 24, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants