Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: losing redirect on provider login #5970

Merged
merged 15 commits into from
Jan 19, 2024
Merged

Fix: losing redirect on provider login #5970

merged 15 commits into from
Jan 19, 2024

Conversation

andreas-unleash
Copy link
Contributor

@andreas-unleash andreas-unleash commented Jan 19, 2024 •
edited
Loading

Fixes the initial redirect to take into account the value from session storage

@andreas-unleash
fix: store redirect to localStorage to avoid loss of redirect
b3be3e6 
Signed-off-by: andreas-unleash <[email protected]>
@andreas-unleash
fix: store redirect to localStorage to avoid loss of redirect
d60bcd7 
Signed-off-by: andreas-unleash <[email protected]>
@andreas-unleash
Merge branch 'main' into fix/losing_redirect_on_provider_login
96431b6
@andreas-unleash
clear localStorage item on successful login
91f082e 
Signed-off-by: andreas-unleash <[email protected]>
@andreas-unleash
linter
ce886e1 
Signed-off-by: andreas-unleash <[email protected]>
@andreas-unleash
add optional timeToLive to local storage for setting expirating time …
c66147a 
…for our values

Signed-off-by: andreas-unleash <[email protected]>
@andreas-unleash
add optional timeToLive to local storage for setting expirating time …
0cb43ec 
…for our values

Signed-off-by: andreas-unleash <[email protected]>
@andreas-unleash
fix test
2d29fc6 
Signed-off-by: andreas-unleash <[email protected]>
@andreas-unleash
fix test
321f6fd 
Signed-off-by: andreas-unleash <[email protected]>
@andreas-unleash
replace with session storage
ecd3d73 
Signed-off-by: andreas-unleash <[email protected]>
@andreas-unleash
replace with session storage
77b09df 
Signed-off-by: andreas-unleash <[email protected]>
@andreas-unleash
default value to undefined on set
13eec0b 
Signed-off-by: andreas-unleash <[email protected]>
@andreas-unleash
fix: add session storage stored login-redirect as override for initia…
94e56b4 
…l redirect

Signed-off-by: andreas-unleash <[email protected]>
@andreas-unleash
Merge branch 'main' into fix/losing_redirect_on_provider_login
17b9a8a
@vercel Vercel
Copy link

vercel bot commented Jan 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 10:47am
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 10:47am

@andreas-unleash andreas-unleash changed the title Fix/losing redirect on provider login Fix: losing redirect on provider login Jan 19, 2024
@kwasniew kwasniew self-requested a review January 19, 2024 12:31
@andreas-unleash andreas-unleash merged commit dda0fd3 into main Jan 19, 2024
12 checks passed
@andreas-unleash andreas-unleash deleted the fix/losing_redirect_on_provider_login branch January 19, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwasniew kwasniew kwasniew approved these changes

@FredrikOseberg FredrikOseberg Awaiting requested review from FredrikOseberg

Assignees

@andreas-unleash andreas-unleash

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreas-unleash @kwasniew