refactor: add typesafe wrappers for prom client metrics #5969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunogois
requested review from
ivarconr,
chriswk,
gastonfournier,
gardleopard and
sighphyre
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
nunogois
commented
Jan 19, 2024
| toggle: featureName, | ||
| project, | ||
| environment: 'default', | ||
| environmentType: 'production', |
There was a problem hiding this comment.
I assume these environment and environmentType values are on purpose? I found it weird that these ones are specified, but not the others.
nunogois
force-pushed
the
refactor-prom-client-typesafe-wrappers
branch
from
0fc3102 to
d5e32aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-1856/add-typesafe-wrappers-over-prom-clients-metrics
As discussed on the latest knowledge sharing session, this adds typesafe wrappers over prom client's metrics, requiring us to specify all the configured labels for each metric.
This uses a functional approach and only exposes the methods that are currently relevant to us, while also exposing the underlying instance of the metric for an easy access if needed.
Since we often chain
labelswithincin counters, this adds a convenienceincrementmethod for counters which does both in a single call.