Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table loader #5937

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix: table loader #5937

merged 1 commit into from
Jan 18, 2024

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Jan 17, 2024

About the changes

Bug: loaders in the table were cancelled before data arrived

Root cause:
Screenshot 2024-01-17 at 16 14 38

Solution:
Give a loader at the top level (in Project) a very specific identifier for things it should load so that very deeply nested loaders are not affected and can have their local loading hooks.

Important files

Discussion points

Copy link

vercel bot commented Jan 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 3:30pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2024 3:30pm

Copy link
Member

@nunogois nunogois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwasniew kwasniew merged commit 567099a into main Jan 18, 2024
14 checks passed
@kwasniew kwasniew deleted the fix-table-loader branch January 18, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants