refactor: move search implementation out of strategies store (#5642)

This is first step of refactoring. Next steps follow with possibly a
query builder, or atleast using some reusable methods.

src/lib/db/index.ts

@@ -39,6 +39,7 @@ import { ImportTogglesStore } from '../features/export-import-toggles/import-tog
 import PrivateProjectStore from '../features/private-project/privateProjectStore';
 import { DependentFeaturesStore } from '../features/dependent-features/dependent-features-store';
 import LastSeenStore from '../services/client-metrics/last-seen/last-seen-store';
+import FeatureSearchStore from '../features/feature-search/feature-search-store';
 
 export const createStores = (
     config: IUnleashConfig,
@@ -139,6 +140,7 @@ export const createStores = (
         privateProjectStore: new PrivateProjectStore(db, getLogger),
         dependentFeaturesStore: new DependentFeaturesStore(db),
         lastSeenStore: new LastSeenStore(db, eventBus, getLogger),
+        featureSearchStore: new FeatureSearchStore(db, eventBus, getLogger),
     };
 };
 

src/lib/features/feature-search/createFeatureSearchService.ts

@@ -1,35 +1,34 @@
 import { Db } from '../../db/db';
 import { IUnleashConfig } from '../../types';
 
-import FeatureStrategiesStore from '../feature-toggle/feature-toggle-strategies-store';
 import { FeatureSearchService } from './feature-search-service';
-import FakeFeatureStrategiesStore from '../feature-toggle/fakes/fake-feature-strategies-store';
+import FakeFeatureSearchStore from './fake-feature-search-store';
+import FeatureSearchStore from './feature-search-store';
 
 export const createFeatureSearchService =
     (config: IUnleashConfig) =>
     (db: Db): FeatureSearchService => {
         const { getLogger, eventBus, flagResolver } = config;
-        const featureStrategiesStore = new FeatureStrategiesStore(
+        const featureSearchStore = new FeatureSearchStore(
             db,
             eventBus,
             getLogger,
-            flagResolver,
         );
 
         return new FeatureSearchService(
-            { featureStrategiesStore: featureStrategiesStore },
+            { featureSearchStore: featureSearchStore },
             config,
         );
     };
 
 export const createFakeFeatureSearchService = (
     config: IUnleashConfig,
 ): FeatureSearchService => {
-    const fakeFeatureStrategiesStore = new FakeFeatureStrategiesStore();
+    const fakeFeatureSearchStore = new FakeFeatureSearchStore();
 
     return new FeatureSearchService(
         {
-            featureStrategiesStore: fakeFeatureStrategiesStore,
+            featureSearchStore: fakeFeatureSearchStore,
         },
         config,
     );

src/lib/features/feature-search/fake-feature-search-store.ts

@@ -0,0 +1,15 @@
+import { IFeatureOverview } from 'lib/types';
+import {
+    IFeatureSearchParams,
+    IQueryParam,
+} from '../feature-toggle/types/feature-toggle-strategies-store-type';
+import { IFeatureSearchStore } from './feature-search-store-type';
+
+export default class FakeFeatureSearchStore implements IFeatureSearchStore {
+    searchFeatures(
+        params: IFeatureSearchParams,
+        queryParams: IQueryParam[],
+    ): Promise<{ features: IFeatureOverview[]; total: number }> {
+        throw new Error('Method not implemented.');
+    }
+}

src/lib/features/feature-search/feature-search-service.ts

@@ -1,9 +1,8 @@
 import { Logger } from '../../logger';
 import {
-    IFeatureStrategiesStore,
+    IFeatureSearchStore,
     IUnleashConfig,
     IUnleashStores,
-    serializeDates,
 } from '../../types';
 import {
     IFeatureSearchParams,
@@ -12,22 +11,20 @@ import {
 } from '../feature-toggle/types/feature-toggle-strategies-store-type';
 
 export class FeatureSearchService {
-    private featureStrategiesStore: IFeatureStrategiesStore;
+    private featureSearchStore: IFeatureSearchStore;
     private logger: Logger;
     constructor(
-        {
-            featureStrategiesStore,
-        }: Pick<IUnleashStores, 'featureStrategiesStore'>,
+        { featureSearchStore }: Pick<IUnleashStores, 'featureSearchStore'>,
         { getLogger }: Pick<IUnleashConfig, 'getLogger'>,
     ) {
-        this.featureStrategiesStore = featureStrategiesStore;
+        this.featureSearchStore = featureSearchStore;
         this.logger = getLogger('services/feature-search-service.ts');
     }
 
     async search(params: IFeatureSearchParams) {
         const queryParams = this.convertToQueryParams(params);
         const { features, total } =
-            await this.featureStrategiesStore.searchFeatures(
+            await this.featureSearchStore.searchFeatures(
                 {
                     ...params,
                     limit: params.limit,

src/lib/features/feature-search/feature-search-store-type.ts

@@ -0,0 +1,15 @@
+import {
+    IFeatureSearchParams,
+    IQueryParam,
+} from '../feature-toggle/types/feature-toggle-strategies-store-type';
+import { IFeatureOverview } from '../../types';
+
+export interface IFeatureSearchStore {
+    searchFeatures(
+        params: IFeatureSearchParams,
+        queryParams: IQueryParam[],
+    ): Promise<{
+        features: IFeatureOverview[];
+        total: number;
+    }>;
+}