chore: remove featureSearchFrontend flag (#6066)

Unleash · Jan 31, 2024 · c6a2303 · c6a2303
1 parent b2c127c
commit c6a2303
Show file tree

Hide file tree

Showing 17 changed files with 24 additions and 1,252 deletions.
diff --git a/frontend/cypress/integration/projects/overview.spec.ts b/frontend/cypress/integration/projects/overview.spec.ts
@@ -14,8 +14,7 @@ describe('project overview', () => {
     const featureToggleName = `${featureTogglePrefix}-${randomId}`;
     const projectName = `unleash-e2e-project-overview-${randomId}`;
     const baseUrl = Cypress.config().baseUrl;
-    const selectAll =
-        '[title="Toggle All Rows Selected"] input[type="checkbox"]';
+    const selectAll = '[title="Select all rows"] input[type="checkbox"]';
 
     before(() => {
         cy.runBefore();

diff --git a/frontend/src/component/feature/FeatureToggleList/FeatureToggleListTable.test.tsx b/frontend/src/component/feature/FeatureToggleList/FeatureToggleListTable.test.tsx
@@ -35,12 +35,6 @@ const setupNoFeaturesReturned = () =>
     });
 
 const setupApi = (features: APIFeature[], projects: APIProject[]) => {
-    testServerRoute(server, '/api/admin/ui-config', {
-        flags: {
-            featureSearchFrontend: true,
-        },
-    });
-
     testServerRoute(server, '/api/admin/projects', {
         projects,
     });
@@ -146,6 +140,6 @@ test('Filter table by project', async () => {
         'No feature toggles found matching your criteria. Get started by adding a new feature toggle.',
     );
     expect(window.location.href).toContain(
-        '?sort=createdAt&order=desc&offset=0&columns=&project=IS%3Aproject-b',
+        '?offset=0&columns=&project=IS%3Aproject-b',
     );
 }, 10000);
diff --git a/frontend/src/component/feature/FeatureToggleList/FeatureToggleListTable.tsx b/frontend/src/component/feature/FeatureToggleList/FeatureToggleListTable.tsx
@@ -50,7 +50,6 @@ import { usePersistentTableState } from 'hooks/usePersistentTableState';
 import { FeatureTagCell } from 'component/common/Table/cells/FeatureTagCell/FeatureTagCell';
 import { FeatureSegmentCell } from 'component/common/Table/cells/FeatureSegmentCell/FeatureSegmentCell';
 import { useUiFlag } from 'hooks/useUiFlag';
-import { FeatureToggleListTable as LegacyFeatureToggleListTable } from './LegacyFeatureToggleListTable';
 import { FeatureToggleListActions } from './FeatureToggleListActions/FeatureToggleListActions';
 import useLoading from 'hooks/useLoading';
 import { usePlausibleTracker } from 'hooks/usePlausibleTracker';
@@ -68,7 +67,7 @@ export const featuresPlaceholder = Array(15).fill({
 const columnHelper = createColumnHelper<FeatureSearchResponseSchema>();
 const feedbackCategory = 'search';
 
-const FeatureToggleListTableComponent: VFC = () => {
+export const FeatureToggleListTable: VFC = () => {
     const theme = useTheme();
     const { openFeedback } = useFeedback(feedbackCategory, 'automatic');
     const { trackEvent } = usePlausibleTracker();
@@ -428,11 +427,3 @@ const FeatureToggleListTableComponent: VFC = () => {
         </PageContent>
     );
 };
-
-export const FeatureToggleListTable: VFC = () => {
-    const featureSearchFrontend = useUiFlag('featureSearchFrontend');
-
-    if (featureSearchFrontend) return <FeatureToggleListTableComponent />;
-
-    return <LegacyFeatureToggleListTable />;
-};