Skip to content

Commit

Permalink
React Tutorial Improvements (#5657)
Browse files Browse the repository at this point in the history
<!-- Thanks for creating a PR! To make it easier for reviewers and
everyone else to understand what your changes relate to, please add some
relevant content to the headings below. Feel free to ignore or delete
sections that you don't think are relevant. Thank you! ❤️ -->

## About the changes
<!-- Describe the changes introduced. What are they and why are they
being introduced? Feel free to also add screenshots or steps to view the
changes if they're visual. -->

We've made some first round updates to the React tutorial:

- making it more SEO-friendly with ordered lists, sequential language,
description of the JS library
- Switched over the demo app to point to an open source project:
[Cypress Real World
App](https://github.com/cypress-io/cypress-realworld-app)
- included best practice considerations for client-side development
- updated URL path to point to `/feature-flag-tutorials/react` for
simplification


## Discussion points
<!-- Anything about the PR you'd like to discuss before it gets merged?
Got any questions or doubts? -->

Would love feedback on if there's a need for more screenshots? Don't
want to be too screenshot-heavy though I imagine.
And need feedback on the descriptions of "Considerations for using
feature flags in react"
https://github.com/Unleash/unleash/compare/react-improvements?expand=1#diff-96d4956f49f80cd76489a72d4d88c2956ce9dcc695f66fe014ad1185e37cb589R21

Want to make sure that what I described makes sense or if it could use
some tweaking to convey the right message clearly.
  • Loading branch information
nnennandukwe authored Dec 21, 2023
1 parent d57e26b commit c44601b
Show file tree
Hide file tree
Showing 10 changed files with 117 additions and 226 deletions.
331 changes: 111 additions & 220 deletions website/docs/feature-flag-tutorials/react/implementing-feature-flags.md

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions website/docusaurus.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,7 @@ module.exports = {
},
{
from: '/topics/feature-flags/tutorials/react/implementing-feature-flags',
to: '/feature-flag-tutorials/react/implementing-feature-flags',
to: '/feature-flag-tutorials/react',
},
{
from: '/topics/feature-flags/tutorials/flutter/a-b-testing',
Expand All @@ -562,8 +562,8 @@ module.exports = {
},
{
from: [
'/tutorials/academy',
'/unleash-academy',
'/tutorials/academy',
'/unleash-academy',
],
to: '/unleash-academy/introduction',
},
Expand Down Expand Up @@ -664,7 +664,7 @@ module.exports = {
to: '/using-unleash/deploy/configuring-unleash-v3',
},
{
from : [
from: [
'/reference/deploy/database-setup',
'/deploy/database-setup',
],
Expand Down Expand Up @@ -692,7 +692,7 @@ module.exports = {
to: '/using-unleash/deploy/google-auth-hook',
},
{
from:[
from: [
'/deploy/migration_guide',
'/reference/deploy/migration-guide',
],
Expand Down Expand Up @@ -794,5 +794,5 @@ module.exports = {
],
clientModules: [
require.resolve('./global.js'),
],
],
};
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added website/static/img/react-tutorial-rwa.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed website/static/img/react-tutorial-tailwind-css.png
Binary file not shown.
Binary file removed website/static/img/react-tutorial-unstyled-nav.png
Binary file not shown.

1 comment on commit c44601b

@vercel
Copy link

@vercel vercel bot commented on c44601b Dec 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.