Refactor: don't use an object for params

Because the types are different, there's no chance of mixing them up
Unleash · Jan 19, 2024 · b937543 · b937543
1 parent 752383b
commit b937543
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 33 deletions.
diff --git a/...onent/changeRequest/ChangeRequest/Changes/Change/strategy-change-diff-calculation.test.ts b/...onent/changeRequest/ChangeRequest/Changes/Change/strategy-change-diff-calculation.test.ts
@@ -63,30 +63,30 @@ describe('Strategy change conflict detection', () => {
     };
 
     test('It ignores property order in strategy comparison', () => {
-        const result = getChangesThatWouldBeOverwritten({
-            currentStrategyConfig: existingStrategy,
-            change: change,
-        });
+        const result = getChangesThatWouldBeOverwritten(
+            existingStrategy,
+            change,
+        );
 
         expect(result).toBeNull();
     });
 
     test('It treats `undefined` or missing segments in old config as equal to `[]` in change', () => {
-        const resultUndefined = getChangesThatWouldBeOverwritten({
-            currentStrategyConfig: {
+        const resultUndefined = getChangesThatWouldBeOverwritten(
+            {
                 ...existingStrategy,
                 segments: undefined,
             },
-            change: change,
-        });
+            change,
+        );
 
         expect(resultUndefined).toBeNull();
 
         const { segments, ...withoutSegments } = existingStrategy;
-        const resultMissing = getChangesThatWouldBeOverwritten({
-            currentStrategyConfig: withoutSegments,
-            change: change,
-        });
+        const resultMissing = getChangesThatWouldBeOverwritten(
+            withoutSegments,
+            change,
+        );
 
         expect(resultMissing).toBeNull();
     });
@@ -128,15 +128,10 @@ describe('Strategy change conflict detection', () => {
         ].flatMap((existing) =>
             [undefinedVariantsInSnapshot, missingVariantsInSnapshot].map(
                 (changeValue) =>
-                    getChangesThatWouldBeOverwritten({
-                        currentStrategyConfig: existing,
-                        change: changeValue,
-                    }),
+                    getChangesThatWouldBeOverwritten(existing, changeValue),
             ),
         );
 
-        console.log('cases', cases);
-
         expect(cases.every((result) => result === null)).toBeTruthy();
     });
 
@@ -176,10 +171,7 @@ describe('Strategy change conflict detection', () => {
             segments: [3],
         };
 
-        const result = getChangesThatWouldBeOverwritten({
-            currentStrategyConfig: withChanges,
-            change: change,
-        });
+        const result = getChangesThatWouldBeOverwritten(withChanges, change);
 
         const { id, name, ...changedProperties } = withChanges;
 
@@ -234,10 +226,10 @@ describe('Strategy change conflict detection', () => {
         };
 
         expect(
-            getChangesThatWouldBeOverwritten({
-                currentStrategyConfig: existingStrategyMod,
-                change: constraintChange,
-            }),
+            getChangesThatWouldBeOverwritten(
+                existingStrategyMod,
+                constraintChange,
+            ),
         ).toBeNull();
     });
 });
diff --git a/.../component/changeRequest/ChangeRequest/Changes/Change/strategy-change-diff-calculation.ts b/.../component/changeRequest/ChangeRequest/Changes/Change/strategy-change-diff-calculation.ts
@@ -12,13 +12,10 @@ type DataToOverwrite<Prop extends keyof IFeatureStrategy> = {
 };
 type ChangesThatWouldBeOverwritten = DataToOverwrite<keyof IFeatureStrategy>[];
 
-export const getChangesThatWouldBeOverwritten = ({
-    currentStrategyConfig,
-    change,
-}: {
-    currentStrategyConfig?: IFeatureStrategy;
-    change: IChangeRequestUpdateStrategy;
-}): ChangesThatWouldBeOverwritten | null => {
+export const getChangesThatWouldBeOverwritten = (
+    currentStrategyConfig: IFeatureStrategy | undefined,
+    change: IChangeRequestUpdateStrategy,
+): ChangesThatWouldBeOverwritten | null => {
     if (change.payload.snapshot && currentStrategyConfig) {
         const hasChanged = (a: unknown, b: unknown) => {
             if (typeof a === 'object') {