Skip to content

Commit

Permalink
fix: chart issues in dark mode (#8414)
Browse files Browse the repository at this point in the history
This PR fixes two issues with the chart in dark mode:
1. Grid lines are almost invisible
2. Placeholder data lines are way too bright

The fix for both is to use the theme's divider color.


![image](https://github.com/user-attachments/assets/1064d081-0cd8-4b2b-97a7-225e29b3af19)


![image](https://github.com/user-attachments/assets/4f046f98-5664-421a-b0a8-620f2dbe96f9)
  • Loading branch information
thomasheartman authored Oct 10, 2024
1 parent e6365d8 commit 5df7b15
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 6 deletions.
16 changes: 10 additions & 6 deletions frontend/src/component/personalDashboard/FlagMetricsChart.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import annotationPlugin from 'chartjs-plugin-annotation';
import { Bar } from 'react-chartjs-2';
import useTheme from '@mui/material/styles/useTheme';
import { type FC, useEffect, useMemo, useState } from 'react';
import { Box, styled } from '@mui/material';
import { Box, type Theme, styled } from '@mui/material';
import { FeatureMetricsHours } from '../feature/FeatureView/FeatureMetrics/FeatureMetricsHours/FeatureMetricsHours';
import GeneralSelect from '../common/GeneralSelect/GeneralSelect';
import { useFeatureMetricsRaw } from 'hooks/api/getters/useFeatureMetricsRaw/useFeatureMetricsRaw';
Expand All @@ -27,17 +27,17 @@ import { FlagExposure } from 'component/feature/FeatureView/FeatureOverview/Feat

const defaultYes = [0, 14, 28, 21, 33, 31, 31, 22, 26, 37, 31, 14, 21, 14, 0];

const placeholderData = {
const placeholderData = (theme: Theme) => ({
labels: Array.from({ length: 15 }, (_, i) => i + 1),
datasets: [
{
data: defaultYes,
backgroundColor: '#EAEAED',
hoverBackgroundColor: '#EAEAED',
backgroundColor: theme.palette.divider,
hoverBackgroundColor: theme.palette.divider,
label: 'No metrics for this feature flag in the selected environment and time period',
},
],
};
});

const ChartWrapper = styled('div')({
width: '90%',
Expand All @@ -50,10 +50,14 @@ export const PlaceholderFlagMetricsChart = () => {
return createPlaceholderBarChartOptions(theme);
}, [theme]);

const data = useMemo(() => {
return placeholderData(theme);
}, [theme]);

return (
<ChartWrapper>
<Bar
data={placeholderData}
data={data}
options={options}
aria-label='A placeholder bar chart with a single feature flag exposure metrics'
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ export const createPlaceholderBarChartOptions = (
},
grid: {
drawBorder: false,
color: theme.palette.divider,
},
},
},
Expand Down

0 comments on commit 5df7b15

Please sign in to comment.