chore: featureToggleService use optionallyDisableFeature instead of d…

…uplicating logic (#9073)
Unleash · Jan 9, 2025 · 0dbecd7 · 0dbecd7
1 parent b0434c9
commit 0dbecd7
Showing 1 changed file with 6 additions and 20 deletions.
diff --git a/src/lib/features/feature-toggle/feature-toggle-service.ts b/src/lib/features/feature-toggle/feature-toggle-service.ts
@@ -983,28 +983,14 @@ class FeatureToggleService {
 
         await this.featureStrategiesStore.delete(id);
 
-        const featureStrategies =
-            await this.featureStrategiesStore.getStrategiesForFeatureEnv(
-                projectId,
-                featureName,
-                environment,
-            );
-
-        const hasOnlyDisabledStrategies = featureStrategies.every(
-            (strategy) => strategy.disabled,
+        // Disable the feature in the environment if it only has disabled strategies
+        await this.optionallyDisableFeature(
+            featureName,
+            environment,
+            projectId,
+            auditUser,
         );
 
-        if (hasOnlyDisabledStrategies) {
-            // Disable the feature in the environment if it only has disabled strategies
-            await this.unprotectedUpdateEnabled(
-                projectId,
-                featureName,
-                environment,
-                false,
-                auditUser,
-            );
-        }
-
         const preData = this.featureStrategyToPublic(existingStrategy);
 
         await this.eventService.storeEvent(