Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UnleashSubscriber to the Autoconfiguration #34

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Add UnleashSubscriber to the Autoconfiguration #34

merged 1 commit into from
Dec 3, 2024

Conversation

lbsekr
Copy link
Contributor

@lbsekr lbsekr commented Dec 2, 2024 •
edited
Loading

About the changes

Append the current auto configuration logic and pass a UnleashSubscriber bean to the UnleashConfig.Builder. Using the default @ConditionalOnMissingBean solution to pass a NoOpSubscriber if the implementing project does not define a custom UnleashSubscriber.

Closes #33

chriswk
chriswk approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lbsekr - thank you for your contribution. Giving you a 👍 and will merge once I see the tests go green

@chriswk chriswk self-assigned this Dec 3, 2024
@chriswk chriswk merged commit aebc91a into Unleash:main Dec 3, 2024
2 checks passed
@chriswk
Copy link
Member

chriswk commented Dec 3, 2024

Released as 1.1.1. Will propagate to mirrors over the next two-three hours

@lbsekr
Copy link
Contributor Author

lbsekr commented Dec 3, 2024

Thanks for the quick integration 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriswk chriswk chriswk approved these changes

Assignees

@chriswk chriswk

Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add UnleashSubscriber to the Autoconfiguration
2 participants
@lbsekr @chriswk