Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UnleashSubscriber to the Autoconfiguration #33

Closed
lbsekr opened this issue Dec 2, 2024 · 0 comments · Fixed by #34
Closed

Add UnleashSubscriber to the Autoconfiguration #33

lbsekr opened this issue Dec 2, 2024 · 0 comments · Fixed by #34
Assignees
Labels
enhancement New feature or request

Comments

@lbsekr
Copy link
Contributor

lbsekr commented Dec 2, 2024

Describe the feature request

I want the auto-configure component of this starter to also inject/configure a UnleashSubscriber bean into the Unleash bean.

Background

I do not want to replicate the auto-configuration logic just to configure a UnleashSubscriber in the Unleash Bean.

Solution suggestions

You could append the current auto configuration logic and pass a UnleashSubscriber bean to the UnleashConfig.Builder. Using the default @ConditionalOnMissingBean solution to pass a NoOpSubscriber if the implementing project does not define a custom UnleashSubscriber.

@lbsekr lbsekr added the enhancement New feature or request label Dec 2, 2024
@chriswk chriswk moved this from New to In Progress in Issues and PRs Dec 3, 2024
@chriswk chriswk self-assigned this Dec 3, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants