Docs: define import example for resources #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastonfournier
requested changes
Jan 23, 2024
docs/resources/role.md
Outdated
Comment on lines
16
to
19
| import { | ||
| id = 5 | ||
| to = unleash_role.custom_root_role | ||
| } |
There was a problem hiding this comment.
5 is the id of the predefined Project Member role, maybe we should add it as a resource that is imported rather than a custom_root_role which could be misleading
docs/resources/project_access.md
Outdated
Comment on lines
16
to
19
| import { | ||
| project = "sample" | ||
| to = unleash_project_access.sample_project_access | ||
| } |
There was a problem hiding this comment.
Not sure if this will work, because the resource is being created in line 50. What you can import maybe is the default project access
There was a problem hiding this comment.
Got it thanks. Importing the default project access and overriding the owner (I think)
andreas-unleash
commented
Jan 24, 2024
| name = "DELETE_PROJECT" | ||
| }] | ||
| } | ||
|
|
There was a problem hiding this comment.
Intention here is to import the project member role and override the permissions
andreas-unleash
commented
Jan 24, 2024
| } | ||
|
|
||
| resource "unleash_project_access" "default_project_access" { |
There was a problem hiding this comment.
intention is to import the default project access and override the owner
gastonfournier
requested changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says on the tin. Shows how to use the resource with import
Closes # SR-251