Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update add item to project to use the unleash bot #32

Merged

Conversation

thomasheartman
Copy link
Contributor

@thomasheartman thomasheartman commented Jan 9, 2025

This PR updates the workflow that adds items to the project board to
use the new Unleash bot instead of my personal token.

I believe that all sub-repos (I've only checked three, but I remember copy-pasting that config file everywhere)
are configured with the following job definition, which should make this update automatic and smooth:

jobs:
  add-to-project:
      uses: unleash/.github/.github/workflows/add-item-to-project.yml@main
      secrets: inherit

But interestingly, the previous secret (add to project pat) was never passed along. Maybe that's a feature you get with secrets: inherit? Regardless, I don't think being explicit about the required secrets is a bad thing? 🤷🏼

This PR updates the workflow that adds items to the project board to
use the new Unleash bot instead of my personal token.

I believe that all sub-repos are configured with the following job
definition, which should make this update automatic and smooth:

```yaml
jobs:
  add-to-project:
      uses: unleash/.github/.github/workflows/add-item-to-project.yml@main
      secrets: inherit
```
@thomasheartman thomasheartman requested a review from chriswk January 9, 2025 12:25
Copy link
Member

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks good. Might be worth it to update to v1 of the add-to-project action as well. Can be done in a separate PR, so no blocker for me
👍

@thomasheartman thomasheartman merged commit 6518dbf into main Jan 9, 2025
1 check passed
@thomasheartman thomasheartman deleted the chore/add-unleash-bot-stuff-to-add-item-to-project branch January 9, 2025 12:35
thomasheartman added a commit that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants