Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UUM-87263 Fix issue where macOS machines set to Morocco/Casablanca timezone were one hour behind #2103

Merged

Conversation

kkukshtel-unity
Copy link

@kkukshtel-unity kkukshtel-unity commented Dec 20, 2024

Sourced from this fix from coreclr dotnet/runtime#458

More info on the fix context in this comment:
dotnet/runtime#31331 (comment)

  • Should this pull request have release notes?
    • Yes
    • No
  • Do these changes need to be back ported?
    • Yes
    • No
  • Do these changes need to be upstreamed to mono/mono or dotnet/runtime repositories?
    • Yes
    • No

Reviewers: please consider these questions as well! ❤️

Release notes

Fixed UUM-87263 @kkukshtel:
Mono: Fixed issue where macOS machines set to Morocco/Casablanca Timezone were one hour behind

Backports
2022.3
6000.0
6000.1

@unity-cla-assistant
Copy link
Collaborator

unity-cla-assistant commented Dec 20, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@bholmes bholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One item highlighted for nullable AdjustmentRule. Otherwise LGTM

@bholmes
Copy link
Member

bholmes commented Dec 20, 2024

Actually you need some info filled out in the PR description section.

The release notes section and backports section needs filled out.

You will also need to create more PRs for backport branches, but land this first.

Copy link
Collaborator

@UnityAlex UnityAlex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fill out PR's release notes section so they can be included when this makes it into a release.

Copy link
Collaborator

@UnityAlex UnityAlex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants