Skip to content
This repository was archived by the owner on Sep 4, 2024. It is now read-only.

Make integration tests more extensible #344

Merged
merged 5 commits into from
Feb 1, 2024
Merged

Make integration tests more extensible #344

merged 5 commits into from
Feb 1, 2024

Conversation

zhongeric
Copy link
Collaborator

@zhongeric zhongeric commented Feb 1, 2024

There's a ton of duplicated code in the integration tests that we should remove. This will make the addition of new quote types much easier

Diff is kind of messy from yarn fix but essentially:

  • Created new BaseIntegrationTestSuite class that internalizes helper functions like checking quote tokens, execution, etc. As well as having default setup logic
  • In classic and uniswapx tests we run the base class setup and call base class methods when applicable

@zhongeric zhongeric marked this pull request as ready for review February 1, 2024 18:59
Copy link
Member

@ConjunctiveNormalForm ConjunctiveNormalForm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this this sick, thanks for the change!!

@zhongeric zhongeric merged commit 8f894ca into main Feb 1, 2024
6 checks passed
@zhongeric zhongeric deleted the base-integ-tests branch February 1, 2024 22:45
jsy1218 pushed a commit that referenced this pull request Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants