CURA-12352 different minimum layer time for layers that contain overhangs #2187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wawanbreton
changed the title
…ang' into CURA-12352_different-minimum-layer-time-for-layers-that-contain-overhangs
…er-time-for-layers-that-contain-overhangs' into CURA-12352_different-minimum-layer-time-for-layers-that-contain-overhangs
…fferent-minimum-layer-time-for-layers-that-contain-overhangs
Even if the overhang wall speed is set to 100%, and thus wouldn't normally change, the minimum layer time for overhanging walls (split off from the minimum layer time, which is the whole point of this ticket) still should take effect -- which we can't detect if the merged regions are just one big everything blob. part of CURA-12352
done as part of CURA-12352
Since the speed regions can 'too' small as well, we need to make sure we don't create microsegments -- While there was already a mitigation earlier, Ihad to partially undo that to fix a bug, and now it's done in a more guaranteed, explicit way. part of CURA-12352
…layers-that-contain-overhangs
wawanbreton
commented
Jan 20, 2025
CURA-12352 The previous method (filtering intersections) could cause jumps between non-adjacent speed regions, causing the wrong speed to be applied. Now we filter the micro-segments after applying the speed regions, and also re-merge consecutive segments that have the same speed.
rburema
reviewed
Jan 22, 2025
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: 588a838 | Previous: fb54c92 | Ratio |
|---|---|---|---|
SimplifyTestFixture/simplify_slot_noplugin |
1.8697703139041124 ns/iter |
1.2458342521198391 ns/iter |
1.50 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @nallath @jellespijker @wawanbreton @casperlamboo @saumyaj3 @HellAholic
rburema
reviewed
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CURA-12352
Requires Ultimaker/Cura#20039