Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use some accel/jerk settings as Method Bead Mode values #20128

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

shirleydu
Copy link

@shirleydu shirleydu commented Jan 14, 2025

Description

Populate Method series .makerbot files' meta.json with accel override settings, for the print globally and for 'bead modes' pertaining to specific features, per extruder.

Also disallow setting per mesh/extruder/meshgroup for accel/jerk _enabled, _print, _travel, _travel_enabled for method-based printers

Goes with: Ultimaker/synsepalum-dulcificum#29

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Printer definition file(s)
  • Translations

How Has This Been Tested?

  • Sliced for Method printers with the relevant settings populated, checked that they were reflected as expected in the output .makerbot's meta.json

Test Configuration:

  • Operating System: Ubuntu

Checklist:

Populate Method series .makerbot files' meta.json with accel override settings,
for the print globally and for 'bead modes' pertaining to specific features,
per extruder. Currently, extruder-specific bead mode settings will only be
added to the meta.json if the value is non-zero.

Also disallow setting per mesh/extruder/meshgroup for accel/jerk _enabled,
_print, _travel, _travel_enabled for method-based printers
Copy link
Contributor

Test Results

23 370 tests  ±0   23 368 ✅ ±0   46s ⏱️ +2s
     1 suites ±0        2 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 99d10e5. ± Comparison against base commit 75cf32c.

shirleydu and others added 3 commits January 14, 2025 15:28
Disallow setting by per mesh/extruder/meshgroup for accel/jerk _enabled,
_print, _travel, _travel_enabled for method-based printers
This fits more with the parenting structure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant