Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PP-537] Introduce nominal_layer_height #20124

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Frederic98
Copy link
Contributor

@Frederic98 Frederic98 commented Jan 13, 2025

PP-537 - CURA-12020: Introduce nominal_layer_height

Description

This PR introduces the nominal_layer_height setting. This is the layer height that the final part should have. The real layer_height and layer_height_0 become children of this setting.

Rationale

For the Factor 4, we multiply the layer height with the material shrinkage factor. This is done so that an object of 20mm high printed with a 0.2mm layer height, will still have exactly 100 layers. This improves the dimensional accuracy, because otherwise the object might not have an exact whole number of layers.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Printer definition file(s)
  • Translations

How Has This Been Tested?

Ran Cura from source with these changes

Test Configuration:

  • Operating System: Ubuntu

Checklist:

Copy link
Contributor

Test Results

23 370 tests  ±0   23 286 ✅  - 82   46s ⏱️ -8s
     1 suites ±0        2 💤 ± 0 
     1 files   ±0       82 ❌ +82 

For more details on these failures, see this check.

Results for commit 2999b9d. ± Comparison against base commit 382b98e.

Copy link
Member

@rburema rburema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all other printers, the default value is taken for nominal layer height.

How quality profile names appear in 5.9.x:
profile_names_ce3p_in_59

What it looks like with this ticket:
profile_names_ce3p_in_ticket

The 'actual' values for that printer:
values_for_layer_height_settings

One way this could maybe be fixed is if we rename it to nominal layer height for each printer, and then have an upgrader that takes old saved files, checks if the layer height and initial layer height are the same and then sets them to the initial layer height. -- But that's a bit hacky and unreliable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants