Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CURA-12096 move gradual flow plugin back into the engine core #19547

Merged

Conversation

wawanbreton
Copy link
Contributor

Include the extra settings defined by the gradual flow plugin, in the main core.
Also remove all calls to the plugin as a dependancy, as it now part of the engine.

CURA-12096

Comes with Ultimaker/CuraEngine#2133

CURA-12096

This was apparently only useful for the gradual flow plugin. Advised by @jellespijker.
…gin_back_into_the_engine_core' into CURA-12096_move_gradual_flow_plugin_back_into_the_engine_core
Copy link
Contributor

@casperlamboo casperlamboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, good catch renaming the native cad plugin variables!

I think we also need an upgrade script converting all _plugin__curaenginegradualflow__0_1_0__xxx settings to regular settings.

@wawanbreton
Copy link
Contributor Author

I think we also need an upgrade script converting all _plugin__curaenginegradualflow__0_1_0__xxx settings to regular settings.

Yes we do, I added it to the list of "tickets that require an upgrade script for 5.9"

@HellAholic HellAholic merged commit b12e6f9 into main Aug 21, 2024
12 checks passed
@HellAholic HellAholic deleted the CURA-12096_move_gradual_flow_plugin_back_into_the_engine_core branch August 21, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants