-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CURA-12096 move gradual flow plugin back into the engine core #19547
CURA-12096 move gradual flow plugin back into the engine core #19547
Conversation
CURA-12096 This was apparently only useful for the gradual flow plugin. Advised by @jellespijker.
…gin_back_into_the_engine_core' into CURA-12096_move_gradual_flow_plugin_back_into_the_engine_core
…o_the_engine_core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, good catch renaming the native cad plugin variables!
I think we also need an upgrade script converting all _plugin__curaenginegradualflow__0_1_0__xxx
settings to regular settings.
Yes we do, I added it to the list of "tickets that require an upgrade script for 5.9" |
…o_the_engine_core
Include the extra settings defined by the gradual flow plugin, in the main core.
Also remove all calls to the plugin as a dependancy, as it now part of the engine.
CURA-12096
Comes with Ultimaker/CuraEngine#2133