Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CURA-11157] Remove 'support_interface_skip_height' setting #17961

Merged
merged 1 commit into from
Jan 10, 2024
Merged

[CURA-11157] Remove 'support_interface_skip_height' setting #17961

merged 1 commit into from
Jan 10, 2024

Conversation

rburema
Copy link
Member

@rburema rburema commented Jan 10, 2024

Was used for run-time efficiency, but it wasn't really ever set beyond one layer-height, which made it rather useless.

This needed a version-upgrader, since it's the first change that needed it since 5.6

See backend PR: Ultimaker/CuraEngine#2009

@rburema
Remove 'support_interface_skip_height' setting.
c64dcb7 
Was used for run-time efficiency, but it wasn't really ever set beyond one layer-height, which made it rather useless.

frontend part of CURA-11157 -- needed version upgrader as well, since it's the first alteration
@rburema rburema mentioned this pull request Jan 10, 2024
Merged
github-actions[bot]
github-actions bot requested changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/2)

resources/definitions/atmat_signal_pro_base.def.json
@@ -154,7 +154,6 @@
"support_infill_rate": { "value": "20" },
"support_interface_enable": { "value": "True" },
"support_interface_height": { "value": "1" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding support_interface_height with the same value (value: 1) as defined in parent definition: fdmprinter

Suggested change
"support_interface_height": { "value": "1" },

resources/definitions/atmat_signal_pro_base.def.json
@@ -154,7 +154,6 @@
"support_infill_rate": { "value": "20" },
"support_interface_enable": { "value": "True" },
"support_interface_height": { "value": "1" },
"support_interface_skip_height": { "value": "layer_height" },
"support_join_distance": { "value": "1" },
"support_offset": { "value": "1.5" },
"support_pattern": { "default_value": "zigzag" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding support_pattern with the same value (default_value: zigzag) as defined in parent definition: fdmprinter

Suggested change
"support_pattern": { "default_value": "zigzag" },

resources/definitions/biqu_base.def.json
@@ -108,7 +108,6 @@
"support_interface_enable": { "value": true },
"support_interface_height": { "value": "layer_height * 4" },
"support_interface_pattern": { "value": "'grid'" },
"support_interface_skip_height": { "value": 0.2 },
"support_pattern": { "value": "'zigzag'" },
"support_wall_count": { "value": 1 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding support_wall_count with the same value (value: 1) as defined in parent definition: fdmprinter

Suggested change
"support_wall_count": { "value": 1 },

resources/definitions/flyingbear_base.def.json
@@ -92,7 +92,6 @@
"support_interface_height": { "value": "layer_height * 4" },
"support_interface_line_width": { "value": "line_width - 0.1" },
"support_interface_pattern": { "value": "'grid'" },
"support_interface_skip_height": { "value": 0.2 },
"support_pattern": { "value": "'zigzag'" },
"support_wall_count": { "value": 1 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding support_wall_count with the same value (value: 1) as defined in parent definition: fdmprinter

Suggested change
"support_wall_count": { "value": 1 },

resources/definitions/kingroon_base.def.json
@@ -133,7 +133,6 @@
"support_interface_enable": { "value": true },
"support_interface_height": { "value": "layer_height * 4" },
"support_interface_pattern": { "value": "'grid'" },
"support_interface_skip_height": { "value": 0.2 },
"support_pattern": { "value": "'zigzag'" },
"support_wall_count": { "value": 1 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding support_wall_count with the same value (value: 1) as defined in parent definition: fdmprinter

Suggested change
"support_wall_count": { "value": 1 },

resources/definitions/koonovo_base.def.json
@@ -70,7 +70,6 @@
"support_interface_enable": { "value": true },
"support_interface_height": { "value": "layer_height * 4" },
"support_interface_pattern": { "value": "'grid'" },
"support_interface_skip_height": { "value": 0.2 },
"support_pattern": { "value": "'zigzag'" },
"support_wall_count": { "value": 1 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding support_wall_count with the same value (value: 1) as defined in parent definition: fdmprinter

Suggested change
"support_wall_count": { "value": 1 },

resources/definitions/koonovo_kn3.def.json
@@ -88,7 +88,6 @@
"support_interface_enable": { "value": true },
"support_interface_height": { "value": "layer_height * 4" },
"support_interface_pattern": { "value": "'grid'" },
"support_interface_skip_height": { "value": 0.2 },
"support_pattern": { "value": "'zigzag'" },
"support_wall_count": { "value": 1 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding support_wall_count with the same value (value: 1) as defined in parent definition: fdmprinter

Suggested change
"support_wall_count": { "value": 1 },

resources/definitions/koonovo_kn5.def.json
@@ -88,7 +88,6 @@
"support_interface_enable": { "value": true },
"support_interface_height": { "value": "layer_height * 4" },
"support_interface_pattern": { "value": "'grid'" },
"support_interface_skip_height": { "value": 0.2 },
"support_pattern": { "value": "'zigzag'" },
"support_wall_count": { "value": 1 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding support_wall_count with the same value (value: 1) as defined in parent definition: fdmprinter

Suggested change
"support_wall_count": { "value": 1 },

resources/definitions/longer_base.def.json
@@ -109,7 +109,6 @@
"support_interface_enable": { "value": true },
"support_interface_height": { "value": "layer_height * 4" },
"support_interface_pattern": { "value": "'grid'" },
"support_interface_skip_height": { "value": 0.2 },
"support_pattern": { "value": "'zigzag'" },
"support_wall_count": { "value": 1 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding support_wall_count with the same value (value: 1) as defined in parent definition: fdmprinter

Suggested change
"support_wall_count": { "value": 1 },

resources/definitions/mingda_base.def.json
@@ -119,7 +119,6 @@
"support_interface_enable": { "value": true },
"support_interface_height": { "value": "layer_height * 4" },
"support_interface_pattern": { "value": "'grid'" },
"support_interface_skip_height": { "value": 0.2 },
"support_pattern": { "value": "'zigzag'" },
"support_wall_count": { "value": 1 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding support_wall_count with the same value (value: 1) as defined in parent definition: fdmprinter

Suggested change
"support_wall_count": { "value": 1 },

github-actions[bot]
github-actions bot requested changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (2/2)

resources/definitions/tank_m_base.def.json
@@ -70,7 +70,6 @@
"support_interface_enable": { "value": true },
"support_interface_height": { "value": "layer_height * 4" },
"support_interface_pattern": { "value": "'grid'" },
"support_interface_skip_height": { "value": 0.2 },
"support_pattern": { "value": "'zigzag'" },
"support_wall_count": { "value": 1 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding support_wall_count with the same value (value: 1) as defined in parent definition: fdmprinter

Suggested change
"support_wall_count": { "value": 1 },

resources/definitions/vivedino_base.def.json
@@ -99,7 +99,6 @@
"support_interface_enable": { "value": true },
"support_interface_height": { "value": "layer_height * 4" },
"support_interface_pattern": { "value": "'grid'" },
"support_interface_skip_height": { "value": 0.2 },
"support_pattern": { "value": "'zigzag'" },
"support_wall_count": { "value": 1 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding support_wall_count with the same value (value: 1) as defined in parent definition: fdmprinter

Suggested change
"support_wall_count": { "value": 1 },

@casperlamboo casperlamboo merged commit 69c4726 into main Jan 10, 2024
11 checks passed
@casperlamboo casperlamboo deleted the CURA-11157_remove_support_interface_skip_height branch January 10, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] requested changes

@casperlamboo casperlamboo casperlamboo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rburema @casperlamboo