-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile improvements Method #17197
Closed
Closed
Profile improvements Method #17197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pkuiper-ultimaker
commented
Nov 3, 2023
•
edited
Loading
edited
- Disable fan for RapidRinse
- Set small layer temperature RapidRinse equal to print temperature
- Increased size of the prime tower foot
- Bug fix: raft_air_gap --> raft_airgap
Create elegoo_neptune_4pro.def.json for Neptune 4 Pro profile.
Refactor object reload to better handling of 3mf files Make a single file read for all objects from that file, and then replace the objects in scene to the new ones, matching by name. This is also required for an Uranium update to handle the automatic file reload when a file change is detected. 3mf Files can have multiple objects in them. When that is the case, and the file is updated, all objects from that file where being replaced by the first object in the file.
Corrected missing "value" key in "speed_travel" object on line 35
Pros: - Less redundancy between elegoo_base and N4 definition Cons: - Changes in elegoo_base also effect N4 - I don't fully understand what presets get priority over others and when they overwrite or just extend another preset. It works for now but changes in Curas preset parsing/handling may break this profile!
Removed `gantry_height` because it covers the entire build plate and makes printing one at a time practically impossible. The user should manually verify that the printing order is correct, so the external part cooler does not nock of already printed models.
It's basically a Neptune 4
Profiles are mostly copied from elegoo/base. Most hardcoded temperature values were removed, so custom materials settings have an effect.
…eries' into definitions/neptune4pro
…eries' into definitions/neptune4pro
The test `test_validateOverridingDefaultValue` pointed out that some default values are ineffective. This commit removes these default values.
…eries' into definitions/neptune4pro
-added png for makerbots for exception case CURA-11138 CURA-11138
# Conflicts: # conanfile.py
The conditions for the scheduled event in the GitHub installer workflow have been updated. Now it will not only check if the current time is 8 but also if the event is a scheduled one. This ensures the schedule event fires at the right time and under the correct circumstances.
The github actions workflow `installers.yml` has been updated to adjust the daily cron schedule for the main and release branches. Additionally, the conditional logic related to the cura conan version and release tag has been simplified and cleaned up for better readability and maintainability. With these changes, the release process should perform more consistently.
…thod printer is selected CURA-11138
…thod printer is selected CURA-11138
Changed the Github actions workflow by renaming "default-values" to "default_values" across multiple files. In addition, improved environment summary handling by reading its content if the file exists, and finally, appending certain variables to it. This makes the workflow more consistent and better handles the environment summary.
…inting CURA-11138-makerbot-cloud-printing
Adding support for Elegoo Neptune 4 Pro (#16608 follow-up)
Refactor object reload to handle 3mf files
- Set small layer temperature equal to print temperature - Increased size of the prime tower foot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.