Skip to content

Commit

Permalink
Merge pull request #17864 from Ultimaker/CURA-11480-setting-visibilit…
Browse files Browse the repository at this point in the history
…y-check-button

ppr setting was added when it should be excluded
  • Loading branch information
casperlamboo authored Jan 2, 2024
2 parents 24607cd + e66314b commit ce7e8eb
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions resources/qml/Preferences/SettingVisibilityPage.qml
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ UM.PreferencesPage
var idx = -1;
for(var i = 0; i < settingVisibilityPresetsModel.items.length; ++i)
{
if(settingVisibilityPresetsModel.items[i].presetId == settingVisibilityPresetsModel.activePreset)
if(settingVisibilityPresetsModel.items[i].presetId === settingVisibilityPresetsModel.activePreset)
{
idx = i;
break;
Expand Down Expand Up @@ -159,7 +159,7 @@ UM.PreferencesPage
id: definitionsModel
containerId: Cura.MachineManager.activeMachine != null ? Cura.MachineManager.activeMachine.definition.id: ""
showAll: true
exclude: ["machine_settings", "command_line_settings"]
exclude: ["machine_settings", "command_line_settings", "ppr"]
showAncestors: true
expanded: ["*"]
visibilityHandler: UM.SettingPreferenceVisibilityHandler {}
Expand All @@ -173,13 +173,13 @@ UM.PreferencesPage
id: loader

width: settingsListView.width - scrollBar.width
height: model.type != undefined ? UM.Theme.getSize("section").height : 0
height: model.type !== undefined ? UM.Theme.getSize("section").height : 0

property var definition: model
property var settingDefinitionsModel: definitionsModel

asynchronous: true
active: model.type != undefined
active: model.type !== undefined
sourceComponent:
{
switch (model.type)
Expand Down

0 comments on commit ce7e8eb

Please sign in to comment.