Skip to content

Commit

Permalink
Fix wrongful removal of i18n option
Browse files Browse the repository at this point in the history
This caused the option to be always be removed, while we only needed the info of the option to be removed

Contributes to CURA-11497
  • Loading branch information
jellespijker committed Jan 11, 2024
1 parent 69c4726 commit 8f29e8d
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion conanfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,8 @@ def package_id(self):
del self.info.options.cloud_api_version
del self.info.options.display_name
del self.info.options.cura_debug_mode
self.options.rm_safe("enable_i18n")
if self.options.get_safe("enable_i18n", False):
del self.info.options.enable_i18n

# TODO: Use the hash of requirements.txt and requirements-ultimaker.txt, Because changing these will actually result in a different
# Cura. This is needed because the requirements.txt aren't managed by Conan and therefor not resolved in the package_id. This isn't
Expand Down

0 comments on commit 8f29e8d

Please sign in to comment.