-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate API v3 #113
Merged
Merged
Integrate API v3 #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add auth support
…acrostrat into integrate-api-v3 * 'integrate-api-v3' of https://github.com/UW-Macrostrat/macrostrat: Format code and sort imports
…acrostrat into integrate-api-v3 * 'integrate-api-v3' of https://github.com/UW-Macrostrat/macrostrat: Format code and sort imports
…acrostrat into integrate-api-v3 * 'integrate-api-v3' of https://github.com/UW-Macrostrat/macrostrat: Format code and sort imports
…acrostrat into integrate-api-v3 * 'integrate-api-v3' of https://github.com/UW-Macrostrat/macrostrat: Format code and sort imports
…-api-v3 * origin/integrate-api-v3: Format code and sort imports
…acrostrat into integrate-api-v3 * 'integrate-api-v3' of https://github.com/UW-Macrostrat/macrostrat: Format code and sort imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major update to Macrostrat's system architecture. Most notably, it integrates the
api-v3
repository into this one, at a base commit off4fcd6bc
(see also UW-Macrostrat/api-v3#9). This change is necessary because the API v3 system is responsible for writing data into Macrostrat's database, handling authentication, and other functions intimately coupled to Macrostrat's core database design. Binding the API v3 closely to the core management scripts will allow more code to be shared between the CLI, API, and future "task runners" that will handle more complex actions in the background.In addition to this change, several other major changes have been added:
is_finalized
flag for maps that avoids expensive checking at runtime