Add PRIMED CC admins to groups created by this project #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a setting indicating the name of the PRIMED_CC_ADMINS group (by default PRIMED_CC_ADMINS in prod). When creating CDSA groups automatically in the app, add this group to those groups as an admin.
Like for the CDSA group, automatically create an admin membership for the dbGaP application access groups.
Add tests that check behavior when creating CDSA group-admin memberships.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
==========================================
+ Coverage 98.27% 98.29% +0.01%
==========================================
Files 232 232
Lines 17829 18024 +195
==========================================
+ Hits 17522 17717 +195
Misses 307 307 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some apps in this project create groups on AnVIL (e.g., the dbGaP access group, the CDSA access and uploader groups). When groups are created automatically like this, add the CC ADMINS as an admin of the newly created groups.
Closes #360