Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Odd length tcpdump packets #2

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Odd length tcpdump packets #2

merged 3 commits into from
Feb 5, 2025

Conversation

mills95
Copy link

@mills95 mills95 commented Dec 6, 2024

Checks if TcpdumpEventParser::PackHexLine had an odd number of bytes and handles final byte.

In TcpdumpEventParser::GetNextPacketEvent reads seconds as double.

Fixes #1

weston-nrl
weston-nrl reviewed Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@weston-nrl weston-nrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 4559 can also be changed -- sec no longer needs to be cast to double.

@weston-nrl weston-nrl requested a review from bebopagogo December 6, 2024 21:38
@weston-nrl weston-nrl merged commit 1344e3c into USNavalResearchLaboratory:master Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weston-nrl weston-nrl weston-nrl left review comments

@bebopagogo bebopagogo Awaiting requested review from bebopagogo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PackHexLine fails reading odd length packets
2 participants
@mills95 @weston-nrl