Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug #60 via not deleting tempdir until finished processing sample loop #61

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

hyphaltip
Copy link
Contributor

This should fix qiime q2_itsexpress #60 bug due to removal of the tempdir after first round of sample processing.

Copy link
Member

@arivers arivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes appear to solve the issue and pass tests. I'm approving. I'll add some specific test code for this case to verify prior to releasing a new version. I also need to bump the hmmer version to match Qiime 2024.10.

@arivers arivers merged commit 5df360e into USDA-ARS-GBRU:main Jan 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants