Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 물품거래 및 스크랩 API 리팩토링 #86

Merged
merged 8 commits into from
Sep 18, 2024

Conversation

chaechaen
Copy link
Member

📝작업 내용 / 스크린샷

  • ResponseDTO에 from 메서드 추가
  • UserDetails에서 User 객체를 가져오도록 수정
  • Response Entity 응답 상태코드 ok로 통일
  • 엔티티 setter 어노테이션 제외
  • request body에서 userId 제외
  • GlobalExceptionHandler로 예외처리 수정
  • 물품거래글 및 스크랩 조회 시 paging 추가

Copy link
Contributor

@Haewonny Haewonny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 확인했습니다! 수고 많으셨어요 👍🏻

Copy link
Contributor

@ri-naa ri-naa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정사항 모두 확인했습니다!! 수고하셨습니다☺️

Copy link
Contributor

@isuHan isuHan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ResponseDTO, user객체 수정, 페이징 기능 모두 확인했습니다. 수고하셨습니다!

@isuHan isuHan merged commit c675b36 into main Sep 18, 2024
2 checks passed
@ri-naa ri-naa changed the title [Refactor] 물품거래 및 스크랩 API 리팩토링 refactor: 물품거래 및 스크랩 API 리팩토링 Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants