refactor: 동행구하기 API 리팩토링 #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haewonny
reviewed
Sep 15, 2024
| CompanyPost companyPost = companyPostRepository.findById(companyPostId) | ||
| .orElseThrow(() -> new RuntimeException("게시글을 찾을 수 없습니다. ID: " + companyPostId)); | ||
| .orElseThrow(() -> new BadRequestException(ResponseCode.ROW_DOES_NOT_EXIST, "게시글을 찾을 수 없습니다. ID: " + companyPostId)); |
There was a problem hiding this comment.
예외처리 잘 적용된 것 같네요!!
수고하셨습니다 :)
Haewonny
approved these changes
Sep 15, 2024
ri-naa
approved these changes
Sep 15, 2024
ri-naa
reviewed
Sep 17, 2024
| @RequestParam(required = false) LocalDate startDate, | ||
| @RequestParam(required = false) LocalDate endDate, | ||
| @RequestParam(required = false) Gender gender, | ||
| @RequestParam(required = false) String country, | ||
| @AuthenticationPrincipal UserDetails userDetails) { | ||
| Pageable pageable) { |
There was a problem hiding this comment.
이 부분 @ParameterObject Pageable pageable로 하면 더 좋을 것 같습니다!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝작업 내용 / 스크린샷