feat(walletManager): add shouldRecordUsage option and tests #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
md0x
requested review from
mrice32,
chrismaree,
Reinis-FRP and
daywiss
as code owners
md0x
commented
Sep 18, 2024
| } | ||
| } | ||
| } | ||
| let selectedWallet = this.findAssignedWallet(ovalInstance); |
There was a problem hiding this comment.
Small refactoring to simplify getSharedWallet by pulling out this logic.
md0x
force-pushed
the
pablo/find-unlock-shared-wallets
branch
2 times, most recently
from
36b98db to
877b870
Compare
Signed-off-by: Pablo Maldonado <[email protected]>
md0x
force-pushed
the
pablo/find-unlock-shared-wallets
branch
from
877b870 to
75e2276
Compare
md0x
changed the title
mrice32
approved these changes
Sep 19, 2024
| @@ -99,7 +101,7 @@ export const getUnlockBundlesFromOvalAddresses = async ( | |||
| targetBlock, | |||
| ovalAddress, | |||
| req, | |||
| false, | |||
| false, // Do not simulate | |||
There was a problem hiding this comment.
What does this comment mean? If we're not simulating, wouldn't this be true...?
There was a problem hiding this comment.
Simulate has a default value of true, but here we are not simulating. I added the comment because now we have a second optional boolean argument, shouldRecordWalletUsage, so it’s easier to read.
| ) => { | ||
| const unlocks = await Promise.all( | ||
| getOvalAddresses().map(async (ovalAddress) => | ||
| prepareUnlockTransaction(flashbotsBundleProvider, backrunTxs, targetBlock, ovalAddress, req), | ||
| // Do not record wallet usage here as we will record it in the loop below once we find a valid unlock. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
shouldRecordUsageoptional boolean argument togetWalletandgetSharedWalletmethods.shouldRecordUsageoption.