Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing natspec for coinbase adapter #15

Merged
merged 1 commit into from
May 20, 2024
Merged

fix: add missing natspec for coinbase adapter #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/adapters/source-adapters/CoinbaseSourceAdapter.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ abstract contract CoinbaseSourceAdapter is DiamondRootOval {
* @param maxTraversal The maximum number of rounds to traverse when looking for historical data.
* @return answer The answer as of the requested timestamp, or the earliest available data if not available, in 18 decimals.
* @return updatedAt The timestamp of the answer.
* @return roundId The roundId of the answer (hardcoded to 1 for Coinbase).
*/
function tryLatestDataAt(uint256 timestamp, uint256 maxTraversal)
public
Expand Down Expand Up @@ -59,6 +60,12 @@ abstract contract CoinbaseSourceAdapter is DiamondRootOval {
return (DecimalLib.convertDecimals(sourceAnswer, SOURCE_DECIMALS, 18), updatedAt);
}

/**
* @notice Returns the requested round data from the source.
* @dev Round data not exposed for Coinbase, so this returns uninitialized data.
* @return answer Round answer in 18 decimals.
* @return updatedAt The timestamp of the answer.
*/
function getSourceDataAtRound(uint256 /* roundId */ ) public view virtual override returns (int256, uint256) {
return (0, 0);
}
Expand Down
Loading