-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use snapshotting library in bounded union source adapter #12
Open
Reinis-FRP
wants to merge
12
commits into
master
Choose a base branch
from
reinis-frp/fix-bounded-union
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+334
−84
Open
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
05b2ae5
test: bounded union source adapter not flipping backward
Reinis-FRP 0fa0033
Merge branch 'master' into reinis-frp/fix-bounded-union
Reinis-FRP c19424b
fix: convert snapshot source to lib
Reinis-FRP 8c2485b
fix: use snapshotting in bounded union source adapter
Reinis-FRP 978a9e1
fix: snapshot aggregated union data
Reinis-FRP 5eb6aea
Merge branch 'master' into reinis-frp/fix-bounded-union
Reinis-FRP 89bad8b
fix: round id in tests
Reinis-FRP 77b162c
fix: pass data struct in internal call
Reinis-FRP d425284
fix: give preference to the snapshot data for same timestamp
Reinis-FRP 424d94e
feat: add maxAge parameter to limit the staleness of a historical dat…
mrice32 9cb7ed6
Merge branch 'master' into reinis-frp/fix-bounded-union
Reinis-FRP 9193e32
Merge branch 'master' into reinis-frp/fix-bounded-union
Reinis-FRP File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: use snapshotting in bounded union source adapter
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
commit 8c2485b50fc264f0a353103c5a61e09800c7657b
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is unrelated. why was it added? it does make sense but given we want the most recent data can we not continue to use those methods?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This attempted to fix the original bug. But now I realize this unnecessarily snapshots source data both in Pyth and Chronicle adapters. Instead, we should snapshot the aggregated union value and use that here - I just refactored this in the latest commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that makes a lot more sence.