New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: Insurance check patterns for Insurance.sol #14

Open

saibaneer wants to merge 1 commit into UMAprotocol:master from saibaneer:insurance-fix

saibaneer commented Jan 31, 2024 •

edited

Loading

Hi! I reviewed the Insurance.sol contract and found the following issues within the issueInsurance function.

The insurance amount was not checked to reject 0 amounts. I ran a test, and the issueInsurance function will pass if the amount is zero, thereby creating a dud policy. You don't want this outcome, as it is unhandled.
To avoid collision I added the block.timestamp, you can ALSO use a universal nonce or block number.
policyId = keccak256(abi.encode(insuredEvent, payoutAddress, block.timestamp));


          add: Insurance check patterns

948ed4a

saibaneer mentioned this pull request

Insurance.issueInsurance() misses 2 check patterns. #15

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet